🌱 refactor basecontroller with sdk-go and move certrotation to sdk-go #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweiyin318
force-pushed
the
refactor-cert
branch
from
2c35266 to
fbabef3
Compare
zhiweiyin318
changed the title
zhiweiyin318
force-pushed
the
refactor-cert
branch
3 times, most recently
from
ab264e4 to
13312d4
Compare
Signed-off-by: Zhiwei Yin <[email protected]>
zhiweiyin318
force-pushed
the
refactor-cert
branch
from
13312d4 to
bde29e7
Compare
qiujian16
reviewed
Jun 21, 2024
@qiujian16 yes, basecontroller has been removed too. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, zhiweiyin318 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a790495
into
open-cluster-management-io:main
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Fixes # #276